A few improvements to DPL InputRecord - #3061
Merged
Merged
Conversation
- fix the end iterator instance of part iterator - making const what should be const - bounds check before getNofParts callback to check against span size - init InputRecord from InputSpan by move (which was intended but there was an unwanted copy) - making InputRecord::get<T>(DataRef) a static method This method actually only requires the pointers from the DataRef argument, no concrete object or state is needed. At some point this can be also seperated from InputRecord, thus separating data and serialization method.
ktf
reviewed
Mar 3, 2020
Comment on lines
+26
to
+29
| InputSpan() = delete; | ||
| InputSpan(InputSpan const&) = delete; | ||
| InputSpan(InputSpan&&) = default; | ||
|
|
Member
There was a problem hiding this comment.
These are fine, but we should also override operator= then.
Member
|
GPU issue unrelated. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an unwanted copy)
This method actually only requires the pointers from the DataRef argument, no
concrete object or state is needed.
At some point this can be also seperated from InputRecord, thus separating data
and serialization method.